-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
print an error message if neo4j is already running #362
Open
xavieryao
wants to merge
581
commits into
neo4j:master
Choose a base branch
from
xavieryao:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r cleanly so upgrade is successful
Replaced curl with wget in the entrypoint
…ndencies that are not on maven central can be picked up (e.g. betas and release candidates)
Add neo4j m2 repo (community) & always run the plugins tests
…ng a pattern from make e.g. make test TESTS='*Plugin*'
… the user has not already set the configuration value in question)
…matically apply default configurations for plugins when installing a plugin
tidying up java test code
add the ability to easily run a particular junit test
use the latest neo4j driver
Improve handling of NEO4J_ config setting env variables
…, fixed and added a test.
Add NEO4JLABS_PLUGINS support for neosemantics (n10s)
This reverts commit a9c12d5
…event neo4j from starting
… by docker. Moved check to enterprise only defaults
…ould now be fixed
In *5.0 Enterprise* edition all user databases are started asynchronously. Meaning when the start is complete ("Started" is printed in the user log) and the http endpoint responds with 200 that does not mean that the user databases and so the default database "neo4j" is available. All tests which assume that, are likely to fail. This change modifies the readiness criteria (only for enterprise && >=5.0) that instead of waiting for 200 on the generic http endpoint it waits for 200 for the database's availability endpoint: /db/<dbname>/cluster/available (for this the caller needs to authenticate).
Refine startup criteria for 5.0-Enterprise containers
This reverts commit ff8ab0f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: neo4j container sometimes fails to start without outputting any message, after being forced to stop.
This happens if the
--time
/stop_grace_period
ofdocker stop
ordocker compose stop
is not long enough, for example the default value 10 seconds. The output ofdocker-neo4j/docker-image-src/4.4/docker-entrypoint.sh
Line 560 in 0c09185
will become
Neo4j is already running (pid:1)
, but the entry point script will not show any error message.It will be really helpful for users to debug if the entry point script could point out why
neo4j console --dry-run
fails, or at least print an error message if the problem is that the pid file already exists and provide some solutions (what I did in this PR).neo4j:4.4-community
. I assume this also applies to other tags.docker version
command