Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the metadata module from near-sdk-macros #1072

Closed
wants to merge 3 commits into from
Closed

Delete the metadata module from near-sdk-macros #1072

wants to merge 3 commits into from

Conversation

uint
Copy link
Contributor

@uint uint commented Aug 18, 2023

Closes #1034

This is breaking and should only be released with a major version bump (5.0.0)!

@uint uint marked this pull request as draft August 18, 2023 09:41
@uint
Copy link
Contributor Author

uint commented Aug 18, 2023 •
edited
Loading

I also deleted the __private::metadata module from near-sdk - it doesn't seem to be used by cargo-near, near-abi or anything of the sort, but please confirm.

@uint uint marked this pull request as ready for review August 18, 2023 10:06
frol
frol approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the conflict and merge it. There are several breaking changes, and I would suggest we release 5.0 sooner rather later, and iterate faster

@frol
Copy link
Collaborator

frol commented Oct 22, 2023

This PR was superseded by #1098

@frol frol closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate metadata module
2 participants
@uint @frol