Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Aggregated Individual Contribution miscalculation #354

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Fixes Aggregated Individual Contribution miscalculation #354

merged 1 commit into from
Oct 31, 2022

Conversation

daltonscharff
Copy link
Contributor

Description

Modifies the getCandidateSummary query to include all contributions where the canon_committee_sboe_id matches the candidate, regardless of whether contributor_id is NULL or not.

Why?

Aggregated individual contributions were not always included in the summary data on the upper right of a candidate's summary page

GitHub Issue

#330

Testing Steps

Checkout this branch and navigate to http://localhost:3000/candidate/STA-C0498N-C-002
Expect that Roy Cooper's Total Number of Aggregated Contributions and Sum of Aggregated Contributions are both greater than 0.

Before and After Screenshots (if applicable)

Note the values in these screenshots reflect a subset of the total transactions (i.e. the calculations are correct, but the numbers are not).

Before

image

After

image

@daltonscharff daltonscharff marked this pull request as draft October 9, 2022 21:47
@daltonscharff daltonscharff marked this pull request as ready for review October 9, 2022 21:50
@SchaeStewart SchaeStewart merged commit 6721a59 into ncopenpass:master Oct 31, 2022
@daltonscharff daltonscharff deleted the bug/330/aggregated-contribution-summary branch October 31, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants