Fixes Aggregated Individual Contribution miscalculation #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the
getCandidateSummary
query to include all contributions where thecanon_committee_sboe_id
matches the candidate, regardless of whether contributor_id isNULL
or not.Why?
Aggregated individual contributions were not always included in the summary data on the upper right of a candidate's summary page
GitHub Issue
#330
Testing Steps
Checkout this branch and navigate to http://localhost:3000/candidate/STA-C0498N-C-002
Expect that Roy Cooper's
Total Number of Aggregated Contributions
andSum of Aggregated Contributions
are both greater than 0.Before and After Screenshots (if applicable)
Note the values in these screenshots reflect a subset of the total transactions (i.e. the calculations are correct, but the numbers are not).
Before
After