MAUI: first steps #279

webwarrior-ws · 2024-05-23T09:07:53Z

Supersedes #274

global.json

knocte · 2024-05-23T09:50:34Z

@webwarrior-ws let's fix the style of the welcomePage, in Linux it looks like this:

.github/workflows/CI.yml

.gitmodules

knocte · 2024-05-23T10:13:26Z

let's fix the style of the welcomePage, in Linux it looks like this:

Looking at same screenshot above, another issue: window title is not the same as geewallet (should be "geewallet", not "GWallet.Frontend.Maui"

knocte · 2024-05-24T11:47:01Z

I found another toolbar-related bug: after sending a payment, and clicking "ok" on the modal dialog that tells me that the transaccion was succesful, the wallet goes back to the ReceivePage but doesn't show a back button:

knocte · 2024-05-24T11:57:38Z

With regards to style, the buttons at the bottom of the pages are always too close to the other widgets, while there should be some padding:

Next button:

Finish button:

Both "Send" and "Cancel" buttons:

I guess what happens is that XamarinForms has some sort of default padding for the stacklayout elements or something, because I see some proper separation in geewallet master branch (even between the textboxes). Example:

knocte · 2024-05-27T22:47:38Z

@webwarrior-ws nit: please fix all commit messages to use the word "scripts", not "Scripts", because this word is matching a folder name in the repo, and it should match its case to avoid any confusions.

scripts/configure.fsx

.github/workflows/CI.yml

scripts/snap_release.fsx

knocte · 2024-05-29T07:31:49Z

src/GWallet.Frontend.XF/FrontendHelpers.fs

                          Padding = Thickness(0.),
                          BorderColor = Color.SeaShell)
        frame

    let private CreateWidgetsForAccount (currency: Currency) currencyLogoImg classId: BalanceWidgets =
        let accountBalanceLabel = CreateLabelWidgetForAccount LayoutOptions.Start
+        // TODO: [FS0044] This construct is deprecated. The StackLayout expansion options are deprecated; please use a Grid instead.
+        // Should remove #nowarn 44 after fixing this.


@webwarrior-ws thanks for adding this comment, but looks like it is misplaced? shouldn't it be placed in function CreateLabelWidgetForAccount?

No, because what causes a warning is usage of LayoutOptions.EndAndExpand, which occurs on the next line

src/GWallet.Frontend.XF/WelcomePage.xaml.fs

knocte · 2024-05-29T07:54:30Z

Nit I found in GTK:

Please compare to master branch, which I guess gives a bit of separation between the "Amount:" label and the "Not enough funds" label.

webwarrior-ws · 2024-05-29T09:35:59Z

Please compare to master branch, which I guess gives a bit of separation between the "Amount:" label and the "Not enough funds" label.

Added padding between labels in Maui/Gtk

Use nuget source instead of Github packages so that there is no need for authentication anymore. Update maui submodule to point to CrossMaui/new branch.

Added stepsto upload generated APK file as CI artifact.

The new MAUI project was not included in the solution so you could not build it in VS4Mac. After trying it, it was giving a clang compiler error, that we avoid with a workaorund in the project file.

Currently crashes the app if using back arrow.

Build MAUI snap (snap_alpha job) in addition to XF snaps. Temporarily remove CI snap_aplha job dependencies. Make MAUI/Gtk app process console args, and if it's "--version", print version and exit without launching UI. Ignore Frontend.Maui in FindOffendingPrintfUsage function as it's not relevant for new .NET versions used by MAUI. Change app name on Gtk so that name can be used in dbus slots declaration in snap. Use snapcraft 7.x for MAUI and continue using snapcraft 6.x for XF.

As a workaround to issue 14 of [1]. [1] https://github.com/canonical/dotnet-snap/

Since dotnet-runtime-6.0 causes the following error when running snap: ``` Error: [/snap/gee-maui-preview/x1/usr/share/dotnet/host/fxr] does not exist ```

Switch to .NET8 to fix bug in Android when using back button in navigation bar crashes the app. Continue using .NET6 for GTK.

To include latest changes regarding Gtk application id. Use default MauiGtkApplication.Name derived from executable name.

Show navigation toolbar only after page is loaded in MAUI. Otherwise, navigation toolbar would show up briefly on old page (BalancesPage in our case) before switching to new page.

To latest version that uses NonUnique flag for Gtk.Application. This removes need for DBus communication, so removed DBus slot from snapcraft.yaml.

Just like it is on Xamarin.

Change Maui submodule to track Mali repository since this is what CrossMaui was renamed to.

Fix window title on Gtk platform.

Show navigation bar on ReceivePage after navigating to it as a result of sending transaction.

Set padding for buttons on Gtk to be consistent with other platforms as they have padding around buttons by default.

Determine frontend to be built in configure script and build it in make script. Have 2 variants of global.json (one for MAUI/Gtk with .NET6 and one for other MAUI platfoprms with .NET8) and choose appropriate one in configure script.

Fix spacing after "Amount" label in SendPage on Gtk platform so that it is the same as on other platforms.

Extracted installation of gtk workload and adding Maui nuget source to separate script to remove code duplication. Renamed DotNetVersion to DotNetVersionForMauiGtk and made it and GtkSharpVersion workflow-level env vars in CI.yml.

Fix WelcomePage layout on MAUI/Gtk by using Mali commit that has better approximation for Label desired size on Gtk.

Switch to using .NET 8 for all frontends. Use Maui 8 on Gtk. This unifies .NET versions and gets rid of .NET 6, which is nearing end of suport anyway. Update Microsoft.Extensions.DependencyInjection to v 8.0.0. This iss needed to avoid error: ``` error NU1605: Warning As Error: Detected package downgrade: Microsoft.Extensions.DependencyInjection from 8.0.0 to 6.0.0. Reference the package directly from the project to select a different version. ``` Install maui workloads on windows--dotnet8-* lanes so that Maui/Android can be built. Call fsxc with DOTNET_ROLL_FORWARD=Major to allow it to run under newer .NET version (we use .NET8 now, and fsxc is compiled for .NET6).

Fix layout regressions in BalancesPage on Maui/Gtk after upgrading to Maui 8.

Implemented workaround for incorrect width of some buttons on Gtk (which were stretched to window width) by introducing 3 columns to grids in ReceivePage and SendPage. Buttons are placed in central column, while other grid children span all 3 columns.

Fixed layout of date picker in WelcomePage on Maui/Gtk. It was way too tall, now it has height of about one line of text, like on other platforms.

Upload alpha (MAUI) snap package to snap store.

webwarrior-ws · 2024-11-26T11:44:42Z

Superseded by #299

knocte mentioned this pull request May 23, 2024

MAUI: first steps #274

Closed

knocte reviewed May 23, 2024

View reviewed changes

global.json Outdated Show resolved Hide resolved

webwarrior-ws force-pushed the maui-conversion branch from f9cd7dd to a78cd9b Compare May 23, 2024 09:48

knocte reviewed May 23, 2024

View reviewed changes

.github/workflows/CI.yml Outdated Show resolved Hide resolved

knocte reviewed May 23, 2024

View reviewed changes

.gitmodules Outdated Show resolved Hide resolved

webwarrior-ws force-pushed the maui-conversion branch 3 times, most recently from 9f9db60 to f38b168 Compare May 23, 2024 12:51

webwarrior-ws force-pushed the maui-conversion branch 2 times, most recently from 62068cc to 640922e Compare May 27, 2024 13:37

knocte reviewed May 27, 2024

View reviewed changes

scripts/configure.fsx Outdated Show resolved Hide resolved

webwarrior-ws force-pushed the maui-conversion branch 2 times, most recently from 9a1456f to 1d05cdf Compare May 28, 2024 09:47

knocte reviewed May 29, 2024

View reviewed changes

.github/workflows/CI.yml Outdated Show resolved Hide resolved

knocte reviewed May 29, 2024

View reviewed changes

scripts/snap_release.fsx Outdated Show resolved Hide resolved

knocte reviewed May 29, 2024

View reviewed changes

src/GWallet.Frontend.XF/WelcomePage.xaml.fs Outdated Show resolved Hide resolved

knocte reviewed May 29, 2024

View reviewed changes

src/GWallet.Frontend.XF/WelcomePage.xaml.fs Outdated Show resolved Hide resolved

webwarrior-ws force-pushed the maui-conversion branch 2 times, most recently from 176bbe2 to 9377843 Compare May 29, 2024 09:30

webwarrior-ws force-pushed the maui-conversion branch 3 times, most recently from 67c1e52 to f7ee056 Compare May 29, 2024 10:25

parhamsaremi and others added 20 commits November 21, 2024 13:17

GithubCI: use nuget source instead of Github

cb7bebf

Use nuget source instead of Github packages so that there is no need for authentication anymore. Update maui submodule to point to CrossMaui/new branch.

CI: upoad APK as CI artifact

6b369e8

Added stepsto upload generated APK file as CI artifact.

sln,Frontend.Maui: allow proj be built in VS4Mac

ae780ca

The new MAUI project was not included in the solution so you could not build it in VS4Mac. After trying it, it was giving a clang compiler error, that we avoid with a workaorund in the project file.

Frontend.Maui: show navigation bar on Android

f3a7694

Currently crashes the app if using back arrow.

snap: use dotnet runtime from packages

dc08742

As a workaround to issue 14 of [1]. [1] https://github.com/canonical/dotnet-snap/

snap: use dotnet-runtime-7.0 in MAUI snap

d8a311f

Since dotnet-runtime-6.0 causes the following error when running snap: ``` Error: [/snap/gee-maui-preview/x1/usr/share/dotnet/host/fxr] does not exist ```

Frontend.Maui: switch to .NET8 for Android

b72a552

Switch to .NET8 to fix bug in Android when using back button in navigation bar crashes the app. Continue using .NET6 for GTK.

Frontend.Maui: update Maui submodule

0c990b6

To include latest changes regarding Gtk application id. Use default MauiGtkApplication.Name derived from executable name.

Frontend.Maui: show nav toolbar after page load

b260d56

Show navigation toolbar only after page is loaded in MAUI. Otherwise, navigation toolbar would show up briefly on old page (BalancesPage in our case) before switching to new page.

Frontend.Maui: update Maui submodule

ef0998b

To latest version that uses NonUnique flag for Gtk.Application. This removes need for DBus communication, so removed DBus slot from snapcraft.yaml.

Frontend.Maui: show navigation bar on SendPage

86d4fbc

Just like it is on Xamarin.

Frontend.Maui: change from CrossMaui to Mali

7cc168c

Change Maui submodule to track Mali repository since this is what CrossMaui was renamed to.

Frontend.Maui: fix title on Gtk

b3583d7

Fix window title on Gtk platform.

Frontend.Maui: show nav bar page after sending tx

be63e8f

Show navigation bar on ReceivePage after navigating to it as a result of sending transaction.

Frontend.Maui: fix button padding on Gtk

a722f01

Set padding for buttons on Gtk to be consistent with other platforms as they have padding around buttons by default.

scripts,CI: determine & build frontend in scripts

f333140

Determine frontend to be built in configure script and build it in make script. Have 2 variants of global.json (one for MAUI/Gtk with .NET6 and one for other MAUI platfoprms with .NET8) and choose appropriate one in configure script.

Frontend.Maui: fix spacing after "Amount" label

f03b4fb

Fix spacing after "Amount" label in SendPage on Gtk platform so that it is the same as on other platforms.

CI,scripts: refactoring of Maui/Gtk builds

6c51e14

Extracted installation of gtk workload and adding Maui nuget source to separate script to remove code duplication. Renamed DotNetVersion to DotNetVersionForMauiGtk and made it and GtkSharpVersion workflow-level env vars in CI.yml.

Frontend.Maui: use fix in Mali for WelcomePage

ea99437

Fix WelcomePage layout on MAUI/Gtk by using Mali commit that has better approximation for Label desired size on Gtk.

webwarrior-ws force-pushed the maui-conversion branch from 24648fd to f936e12 Compare November 21, 2024 12:42

webwarrior-ws added 5 commits November 21, 2024 14:05

Frontend.Maui: fix some layout issues on Maui/Gtk

de776f7

Fix layout regressions in BalancesPage on Maui/Gtk after upgrading to Maui 8.

Frontend(XF,Maui): fix in WelcomePage (datepicker)

9b38226

Fixed layout of date picker in WelcomePage on Maui/Gtk. It was way too tall, now it has height of about one line of text, like on other platforms.

CI,scripts: upload MAUI snap to snap store

b7dd602

Upload alpha (MAUI) snap package to snap store.

webwarrior-ws force-pushed the maui-conversion branch from f0f6f19 to 020e63c Compare November 21, 2024 13:06

webwarrior-ws mentioned this pull request Nov 26, 2024

MAUI: first steps #299

Open

webwarrior-ws closed this Nov 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MAUI: first steps #279

MAUI: first steps #279

webwarrior-ws commented May 23, 2024

knocte commented May 23, 2024

knocte commented May 23, 2024

knocte commented May 24, 2024

knocte commented May 24, 2024

knocte commented May 27, 2024

knocte May 29, 2024

webwarrior-ws May 29, 2024

knocte commented May 29, 2024

webwarrior-ws commented May 29, 2024

webwarrior-ws commented Nov 26, 2024

MAUI: first steps #279

MAUI: first steps #279

Conversation

webwarrior-ws commented May 23, 2024

knocte commented May 23, 2024

knocte commented May 23, 2024

knocte commented May 24, 2024

knocte commented May 24, 2024

knocte commented May 27, 2024

knocte May 29, 2024

Choose a reason for hiding this comment

webwarrior-ws May 29, 2024

Choose a reason for hiding this comment

knocte commented May 29, 2024

webwarrior-ws commented May 29, 2024

webwarrior-ws commented Nov 26, 2024