Linux ARM64 bindings (as with Mac ARM64, no prebuilt available) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has to point to OS / platform-specific versions.
Pointer to i8 is platform-specific, this should let onnxruntime compile on aarch64 with the generated bindings.
Use c_char here as well.
This is WIP but want to make sure committed and pushed to branch so that can resume work on this later.
* Update bindgen config to use `usize` * Update macOS bindings * Update Linux bindings * Update Windows (x86_64) bindings * Update Windows (x86) bindings * Use `usize` instead of `u64` * Use conditional function calling conventions * Re-enable CI for Windows 32bit * Fix CI matrix * Add generated bindings for Apple M1 * On macOS Big Sur, homebrew installs to /opt/homebrew instead of /usr/local, adapt installation notes * Feature is 'generate-bindings', not 'bindgen'. Change error message * Add more paths to include directory, required when compilling and installing from source * Formatting * Compilation notes: environment variable was changed to 'ORT_LIB_LOCATION' (from 'ONNXRUNTIME_INSTALL_DIR') * Add entry to changelog * Add macOS aarch64 to README * Add note about LD_LIBRARY_PATH in README * Add a VSCode config to run clippy and format on save * Clippy: Allow upper case acronyms, names coming from specific ML models * Fix clippy lint: Change 'Into' impls to 'From' * Add ORT_LIB_LOCATION note in readme for 'ORT_STRATEGY=system' * Update changelog following nbigaouette#70 * Update macos/aarch64 bindings following nbigaouette#70 * Formatting * Upgrade 'ndarray' to 0.15 (from 0.13) * Upgrade 'ureq' to 2.1 (from 1.5) * Add changelog entries * Clippy: Box the larse ureq::Error in OrtDownloadError * Release v0.0.12 * Return an Err on shape mismatch instead of panic This way we let the user of the library decide how to handle the issue. Co-authored-by: krazijames <krazijames@gmail.com> Co-authored-by: Nicolas Bigaouette <nbigaouette@gmail.com> Co-authored-by: Keith Lohnes <lohnesk@gmail.com>
tc-wolf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::os::raw::c_charfor c char arraysI've tested this out in a private repo, and the bindings work on arm64 on linux. When I started the fork, onnxruntime-rs was on 0.0.11, so might need some cleanup.
This was built against v1.6.0 of the ONNX runtime.