repo_token is not needed, GH provides a token
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `repo_token` field is optional and will default to `github.token` (see the action [README](https://github.com/svenstaro/upload-release-action/blob/v2/README.md). The `github.token` is autogenerated during workflow runs (see the [documentation](https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication)) and will work just fine for publishing to releases. I have updated this in the [AWX Runner](https://github.com/networktocode-llc/nautobot-plugin-awx-runner/blob/2d8f143693e68863c6b2eac760d09007ada84b4b/.github/workflows/ci.yml#L224) repo and it [worked fine](https://github.com/networktocode-llc/nautobot-plugin-awx-runner/actions/runs/10719631200/job/29724671931).
cmsirbu
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Thanks! Normally this would've been a quick merge, but we're planning on replacing this action completely - see #176.
In the meantime, I don't see any harm in this going in though... thoughts @gsnider2195 @smk4664 ?
|
This will work as long as nobody has changed the default github token permissions in the repo or org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
publish_ghjob thesvenstaro/upload-release-action@v2action does not require arepo_tokenand will default togithub.token(see the action README). Thegithub.tokenis autogenerated during workflow runs (see the documentation) and will work just fine for publishing to releases.I have updated this in the AWX Runner repo and it worked fine.