De-flake TestJetStreamSuperClusterTagInducedMoveCancel
#6160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var cancelResp JSApiStreamUpdateResponse | ||
| require_NoError(t, json.Unmarshal(rmsg.Data, &cancelResp)) | ||
| checkFor(t, 5*time.Second, 0, func() error { |
There was a problem hiding this comment.
Is the test reliable if you have a short interval (i.e. 100*time.Millisecond) instead of 0?
There was a problem hiding this comment.
it should be. let me try edit: worked fine
Request to cancel the move sometimes lands as the stream is being moved and at that point there is not leader hence no response is sent back. With this change we're retrying the request and falling back to the case later in the test where we skip as stream move is not in progress. Signed-off-by: Ziya Suzen <ziya@synadia.com>
mtmk
force-pushed
the
mtmk/de-flake-js-test
branch
from
91ccf2d
to
853e3c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request to cancel the move sometimes lands as the stream is being moved
and at that point there is not leader hence no response is sent back.
With this change we're retrying the request and falling back to the case
later in the test where we skip as stream move is not in progress.
Signed-off-by: Ziya Suzen ziya@synadia.com