Update tests #10
Merged
Update tests #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request significantly enhances the test coverage of our API functionalities, focusing on precision handling in cryptocurrency and OHLC data fetching, as well as improving the robustness of NFT data retrieval methods.
Key Additions:
Precision Parameter Testing: Extended existing tests for
/simple/price,/coins/{id}/ohlc, and/coins/{id}/contract/{contract_address}/market_chart/rangeendpoints to include scenarios where precision parameters are specified. This ensures accurate handling of numerical data at different levels of precision.NFT Collection Data Handling: Introduced new tests to verify the correct functionality of NFT collection data fetching, including edge cases like invalid arguments and empty data responses. This includes tests for
/nfts/{id}and related endpoints, ensuring our API handles various scenarios gracefully.Enhanced Robustness: Additional assertions and mock responses were added to existing tests to cover a broader range of responses and error scenarios, improving the overall robustness of our API test suite.