-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make learning materials page CRUD using the Rails Admin gem #87
Open
Nemwel-Boniface
wants to merge
11
commits into
nairuby:main
Choose a base branch
from
Nemwel-Boniface:make_learning_materials_page_crud
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e8acb37
Update Setup of the rails_admin gem in the project accessed through /…
Nemwel-Boniface 8717427
Update include:
Nemwel-Boniface a6d167f
Update include:
Nemwel-Boniface 5a18fcc
Update include:
Nemwel-Boniface f0da3d4
Update include:
Nemwel-Boniface 78753a1
Update include:
Nemwel-Boniface a2ddd4e
Update include:
Nemwel-Boniface bc13a7f
Update check and fix all found Rubocop offences
Nemwel-Boniface f4e6447
Update include:
Nemwel-Boniface a5b1b1d
Update include:
Nemwel-Boniface a944f54
Update:
Nemwel-Boniface File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
--require spec_helper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# frozen_string_literal: true | ||
Nemwel-Boniface marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
class LearningMaterialsController < ApplicationController | ||
skip_before_action :authenticate_user!, only: %i[index] | ||
|
||
def index | ||
@learning_materials = LearningMaterial.includes(:thumbnail_blob).all | ||
@learning_materials_with_thumbnails = @learning_materials.select do |learning_material| | ||
learning_material.thumbnail.attached? | ||
end | ||
@random_learning_materials = @learning_materials_with_thumbnails.sample(2) | ||
@learning_materials_with_or_without_thumbnails = @learning_materials - @random_learning_materials | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# frozen_string_literal: true | ||
|
||
module LearningMaterialsHelper | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
# frozen_string_literal: true | ||
|
||
class LearningMaterial < ApplicationRecord | ||
# Associations | ||
belongs_to :user | ||
has_one_attached :thumbnail | ||
|
||
# Enum | ||
enum tag: { beginners: 0, intermediates: 1, experts: 2 } | ||
|
||
# Validations | ||
validates :tag, :learning_material_title, :learning_material_description, :learning_material_link, presence: true | ||
validates :learning_material_link, | ||
format: { with: URI::DEFAULT_PARSER.make_regexp(%w[http https]), message: :invalid_url } | ||
end |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i myself prefer Rspec too, if we are going with Rspec, then we need to remove minitest, or make it clear which one we should be using on the project! @JudahSan @banta should we keep Rspec over Minitest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw i'm aware that replacing minitest with rspec will also mean updating the github action to actually run the tests and move any minitest already written
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking forward to your opinions on this @banta and @JudahSan