Safely handle missing credentials.d folder #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$HOME/.aws/credentials.d` folder is not required to exist, as all credential configurations can be defined on `$HOME/.aws/credentials` instead. The early return with the `?` operator caused the binary to fail if the optional folder did not exist, but worked if the folder existed but was empty. This commit refactors the code the avoid crashing when the `$HOME/.aws/credentials.d` does not exist. It is collecting into a Vector instead of chaining the streams as it would required Boxed Streams to switch between `ReadDirStream` and `stream::empty` in case of an `Err`.
|
@bltavares Thank you so much for your fix here! I haven't had much time to fix this nagging issue and I and other users are very grateful for your work. I will be releasing 2.0.1 shortly to include this fix and will mention you in the release notes. |
|
No problem at all. I'm glad to help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$HOME/.aws/credentials.dfolder is not required to exist, as all credential configurations can be defined on$HOME/.aws/credentialsinstead.The early return with the
?operator caused the binary to fail if the optional folder did not exist, but worked if the folder existed but was empty.This commit refactors the code the avoid crashing when the
$HOME/.aws/credentials.ddoes not exist.It is collecting into a Vector instead of chaining the streams as it would required Boxed Streams to switch between
ReadDirStreamandstream::emptyin case of anErr.This fixes #26