Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add composer package setup. #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add composer package setup. #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/vendor/
12 changes: 12 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "mzur/kirby-calendar-plugin",
"description": "A plugin for the Kirby CMS to easily implement an event calendar.",
"type": "composer-plugin",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "composer-plugin",
"type": "library",

"license": "GNU GPL v2",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"license": "GNU GPL v2",
"license": "GPL-2.0-only",

"autoload": {
"psr-4": {
"Mzur\\KirbyCalendarPlugin\\": "src/"
}
Comment on lines +7 to +9
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This won't initialize the plugin correctly, though, as the index.php is no longer executed. Instead, a files autoload section should work:

Suggested change
"psr-4": {
"Mzur\\KirbyCalendarPlugin\\": "src/"
}
"files": [
"index.php"
]

Also, the index.php will need a use statement for the Kirby class, similar to this one.

You could also add authors and support sections.

Could you please apply the changes and test them?

},
"require": {}
}