Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-uwp/src/NavigationView/index.tsx
Line 151 in 096b823
This piece of code seems wrong to me if used with this piece of code:
it makes the
NavigationView
background disappear and first the remaining menu will overlay the content (until clicked / unfocused) and at the same time the whole layout is moved in the original place of theNavigationView
. Or in other words, the logic seems inverted.Also another issue is when the
currInitWidth: 0
is set because then these steps will remove the element completely from user's view and it can't be retrieved back without dev tools:Also, unless either removed completely or replaced with original
props.initWidth
it'll just overwrite user's value which undesired.