Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up register data #36

Merged
merged 4 commits into from
May 30, 2024
Merged

Clean up register data #36

merged 4 commits into from
May 30, 2024

Conversation

DominykasPetke
Copy link
Contributor

Changed

  • Moved the initialization of the map inside the function to avoid a Static Initialization Order Fiasco.
  • Deduplicated the entries
  • Changed the catch to catch a const exception
  • Added an assertion to check if all enumerator values are in the map

@rjonaitis rjonaitis merged commit 94e8377 into myriadrf:develop May 30, 2024
9 checks passed
@DominykasPetke DominykasPetke deleted the DP/static-initialization-order-fiasco branch May 31, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominykasPetke @rjonaitis