Remove extra semicolons to make old compilers happy #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gluttton
changed the title
Gluttton
force-pushed
the
warnings-semicolon
branch
from
77f593a
to
f4d25ab
Compare
Extra (redundant) semicolons are valid in modern C++ (starting from C++11). New versions of the compilers warn of this issue only if the `Wextra-semi` option is explicitly enabled. But old compilers perform this checking implicitly in the scope of the `Wpedantic` option. So, the warning is not reported on modern hosts (e.g., Ubuntu 24.04 with GCC v13.2 and Clang v18.1) but is reported on old hosts (e.g., Debian 11 with GCC v10.2 and Clang v11.0). Although the extra semicolons may be useful in some cases, in this particular case, they seem really redundant, so it is proposed to remove them. Test: build the project with GCC v10.2. Signed-off-by: Gluttton <gluttton@ukr.net>
Gluttton
force-pushed
the
warnings-semicolon
branch
from
f4d25ab
to
8bb86f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details.