Fix FutureWarning in calk.dataset.get_total_salts

mvdh7 · May 10, 2024 · 33867b2 · 33867b2
1 parent 69b65e4
commit 33867b2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/calkulate/dataset.py b/calkulate/dataset.py
@@ -75,7 +75,7 @@ def get_total_salts(ds, inplace=True):
     for salt in salts:
         if salt not in ds:
             ds[salt] = np.nan
-        ds[salt].where(~pd.isnull(ds[salt]), other=results[salt], inplace=True)
+        ds[salt] = ds[salt].where(~pd.isnull(ds[salt]), other=results[salt])
     return ds
 
 

diff --git a/calkulate/meta.py b/calkulate/meta.py
@@ -4,7 +4,7 @@
 
 _authorlist = ["Humphreys, Matthew P.", "Matthews, Ruth S."]
 __author__ = " and ".join(_authorlist)
-__version__ = "23.6.1"
+__version__ = "23.6.2"
 __year__ = 2024
 
 

diff --git a/docs/versions.md b/docs/versions.md
@@ -14,6 +14,9 @@ Calkulate v3 went too far overboard with the OO approach and ended up being very
 
     * Removed excessive `print` statements from debugging.
 
+    ***v23.6.2 bug fixes (forthcoming)***
+
+    * Fix `FutureWarning` in `calk.dataset.get_total_salts`.
 
 ### 23.5 (4 July 2023)