Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: msm8916-samsung: add grandmaxltezc #387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bumagh
Copy link

@bumagh bumagh commented Jul 4, 2024

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended commit messages:

dts: msm8916-samsung: add grandmaxltezc

@@ -841,4 +841,23 @@
};
};
};

grandmaxltezc {
model = "Samsung Galaxy Grand Max (SM-G7200)";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still not sorted in revision order. There are 11 revisions, and 4 < 11.

Update: revision 8 -> 4

@wonderfulShrineMaidenOfParadise
Copy link
Contributor

wonderfulShrineMaidenOfParadise commented Jul 4, 2024

Also add the model, SM-G7200 to Documentation/devices.md.

- Samsung Galaxy Grand Max - SM-G720AX
+ Samsung Galaxy Grand Max - SM-G7200, SM-G720AX

@bumagh bumagh changed the title add grandmaxltezc dts: msm8916-samsung: add grandmaxltezc Jul 6, 2024
@wonderfulShrineMaidenOfParadise
Copy link
Contributor

The commit is not reworded. Use git commit --amend -m "dts: msm8916-samsung: add grandmaxltezc" to apply the commit messages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revision seems to need to be fixed.

lk2nd,dtb-files = "msm8916-samsung-grandmax";

qcom,msm-id = <QCOM_ID_MSM8916 0>;
qcom,board-id = <0xCE08FF01 8>;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
qcom,board-id = <0xCE08FF01 8>;
qcom,board-id = <0xCE08FF01 4>;

The revision is probably not correct, so fastboot boot boot.img would not work.
Grand Max is known to be revision 4.

Ref: https://lxr.trvn.ru/linux-downstream/SM-G720AX/source/arch/arm/boot/dts/samsung/msm8916/msm8916-sec-grandmax-r04.dts#L24

@@ -841,4 +841,23 @@
};
};
};

grandmaxltezc {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To put the nodes in order, move this after node grandmaxlteub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants