-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dts: msm8916-samsung: add grandmaxltezc #387
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommended commit messages:
dts: msm8916-samsung: add grandmaxltezc
@@ -841,4 +841,23 @@ | |||
}; | |||
}; | |||
}; | |||
|
|||
grandmaxltezc { | |||
model = "Samsung Galaxy Grand Max (SM-G7200)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put this after comments, /* rev 4 */
, https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8916/msm8916-samsung.dts#L717
Update: rev 8 -> 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still not sorted in revision order. There are 11 revisions, and 4 < 11.
Update: revision 8 -> 4
Also add the model, - Samsung Galaxy Grand Max - SM-G720AX
+ Samsung Galaxy Grand Max - SM-G7200, SM-G720AX |
The commit is not reworded. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The revision seems to need to be fixed.
lk2nd,dtb-files = "msm8916-samsung-grandmax"; | ||
|
||
qcom,msm-id = <QCOM_ID_MSM8916 0>; | ||
qcom,board-id = <0xCE08FF01 8>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qcom,board-id = <0xCE08FF01 8>; | |
qcom,board-id = <0xCE08FF01 4>; |
The revision is probably not correct, so fastboot boot boot.img
would not work.
Grand Max is known to be revision 4
.
@@ -841,4 +841,23 @@ | |||
}; | |||
}; | |||
}; | |||
|
|||
grandmaxltezc { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To put the nodes in order, move this after node grandmaxlteub
.
No description provided.