Fix-158 #54
Merged
Fix-158 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrigankpawagi why is this held up? Any problem with my changes? If yes, lemme know ill change it |
mrigankpawagi
requested changes
Jan 11, 2024
translation/drafts/158
Outdated
| @@ -10,9 +10,9 @@ | |||
|
|
|||
| """ | |||
| Ek function likho jo strings ki list ko accept karta hai. | |||
| List mein alag alag shabd hote hain. Unique characters ki maximum number wala shabd return karo. Agar multiple strings mein maximum number of unique characters ho, toh lexicographical order mein sabse pehle aane wala shabd return karo. | |||
| List mein alag alag shabd hote hain. Maximum Unique characters ke number wala shabd return karo. Agar multiple strings mein maximum number of unique characters ho, toh lexicographical order mein sabse pehle aane wala shabd return karo. | |||
There was a problem hiding this comment.
"Zabse zyada unique characters wala word return karo"...?
There was a problem hiding this comment.
yeah that sounds much better
Ill change it
translation/drafts/158
Outdated
| @@ -10,9 +10,9 @@ | |||
|
|
|||
| """ | |||
| Ek function likho jo strings ki list ko accept karta hai. | |||
| List mein alag alag shabd hote hain. Unique characters ki maximum number wala shabd return karo. Agar multiple strings mein maximum number of unique characters ho, toh lexicographical order mein sabse pehle aane wala shabd return karo. | |||
| List mein alag alag shabd hote hain. Maximum Unique characters ke number wala shabd return karo. Agar multiple strings mein maximum number of unique characters ho, toh lexicographical order mein sabse pehle aane wala shabd return karo. | |||
|
@mrigankpawagi done, both changes made |
|
Looks good, but please remove the extra line break and change other instances of "shabd" |
|
Yeah done |
mrigankpawagi
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.