Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translation checks for 106-125 #44

Merged
merged 8 commits into from
Jan 23, 2024
Merged

translation checks for 106-125 #44

merged 8 commits into from
Jan 23, 2024

Conversation

sahakintan
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@AnirudhG07 AnirudhG07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first two changes are not needed, 'aise ki' and 'par' are fine only. The other one might be needed.

Copy link
Collaborator

@AnirudhG07 AnirudhG07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial one seems better, dont you think? We can add some English words, after all in spoken Hinglish, they are commonly used.
Else, the order of saamne and peeche is wrong. it should be peeche se (backward) and saamne se(forward).

Copy link
Collaborator

@AnirudhG07 AnirudhG07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here in English docstring, the word 'or' is used after '(', so I think 'ya' is correct, aur means and which is not correct I think w.r.t. English docstring.

@AnirudhG07
Copy link
Collaborator

AnirudhG07 commented Dec 31, 2023

Rest are approved those I have not requested changes of.

if you think the reviews are fine. Change it and merge it into the main branch else let us know.

@mrigankpawagi mrigankpawagi merged commit 7419750 into main Jan 23, 2024
1 check passed
@mrigankpawagi mrigankpawagi deleted the Kintan-translations branch January 23, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants