Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tlsobs main routine. #428

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bernata
Copy link

@bernata bernata commented Aug 15, 2021

Invoke postScan to post to scan endpoint instead of having the code inline.
Added tests for postScan and building url to scan endpoint.

Checklist

  • Run make, gofmt and golint your code, and run a test scan on your local machine before submitting for review.
  • Workers needs an AnalysisPrinter, registered via worker.RegisterPrinter() (which is separate from worker.RegisterWorker()), and imported in tlsobs (example).
  • When adding new columns to the database, also add a DB migration script under database/migrations named the next release (eg. if current release is 1.3.2, migration file will be 1.3.3.sql).
  • When new columns require data to be recomputed, add a script under /tools (example) that updates the database and will be run by administrators.

Invoke `postScan` to post to scan endpoint instead of having the code inline.
Added tests for postScan and building url to scan endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant