Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/256 #258

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issues/256 #258

wants to merge 2 commits into from

Conversation

Parikshit-Hooda
Copy link
Contributor

fixes #256

@Parikshit-Hooda Parikshit-Hooda deleted the issues/256 branch June 29, 2019 22:18
@Parikshit-Hooda Parikshit-Hooda restored the issues/256 branch June 29, 2019 22:18
@Parikshit-Hooda
Copy link
Contributor Author

No idea why CI checks are failing.

@princiya
Copy link
Collaborator

@Parikshit-Hooda the linter is throwing error. see here https://travis-ci.org/mozilla/lightbeam-we/builds/552269812?utm_source=github_status&utm_medium=notification

please revert back the changes so that the linter does not complain.

if you notice the differences here, https://github.com/mozilla/lightbeam-we/pull/258/files, you will get an idea what the linter likes.

princiya
princiya requested changes Jun 30, 2019
View reviewed changes
Copy link
Collaborator

@princiya princiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comply to the linter rules. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@princiya princiya princiya requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

top-bar css issue
2 participants
@Parikshit-Hooda @princiya