Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP DRAFT feat(settings): Update 2FA Settings Row #17978

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

vpomerleau
Copy link
Contributor

@vpomerleau vpomerleau commented Nov 5, 2024

DRAFT FOR EARLY UX REVIEW - needs rebase and hook up after #17998 finalized.

Because

  • We are preparing to add a new recovery method for 2FA and are updating some design pieces

This pull request

  • Update the 2FA settings row design
  • Add new SubRowBackupMethods component
  • Updates stories, tests, l10n

Issue that this pull request solves

Closes: #FXA-10206

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@vpomerleau vpomerleau changed the title feat(settings): Update 2FA Settings Row WIP DRAFT feat(settings): Update 2FA Settings Row Nov 5, 2024
@vpomerleau vpomerleau force-pushed the FXA-10206 branch 2 times, most recently from 5cc246e to 3ec0917 Compare November 5, 2024 22:24
@vpomerleau vpomerleau force-pushed the FXA-10206 branch 3 times, most recently from 29a6b88 to 71ed3e8 Compare November 20, 2024 16:48
Because:

* We are preparing to add a new recovery method for 2FA and are updating some design pieces

This commit:

* Update the 2FA settings row design
* Add new SubRowBackupMethods component
* Updates stories, tests, l10n

Closes #FXA-10206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant