Migrate from make to just #6803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-use-just
branch
13 times, most recently
from
43fe7f3
to
661c814
Compare
relud
commented
Nov 14, 2024
relud
force-pushed
the
relud-use-just
branch
from
661c814
to
b1e6bd4
Compare
willkg
approved these changes
Nov 14, 2024
| # if you clone the repository with a different directory name, then | ||
| # you end up with a different project name and then everything is hosed. | ||
| # Setting it here fixes that. | ||
| COMPOSE_PROJECT_NAME=socorro |
There was a problem hiding this comment.
For my notes, we added this because Alexis needed it because he ran socorro with a differently named directory name.
Because this PR adds a name: socorro, we don't need this anymore.
| # --------------------------------------------- | ||
|
|
||
| # Only use 2 threads for the processor | ||
| producer_consumer.number_of_threads=2 |
There was a problem hiding this comment.
This is probably the last remnants of configman.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also switch from
SOCORRO_UIDandSOCORRO_GIDtoUSE_UIDandUSE_GIDalso switch from
my.envto.envalso switch to using
docker-compose.override.ymlfor volume mounts, so they can be disabled in CI.