Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extra dockerfiles into docker/images/* #6797

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

relud
Copy link
Member

@relud relud commented Nov 4, 2024

to match antenna/eliot/tecken. Fixes syntax highlighting in editors. Makes it more clear when files (e.g. fixtures.json) are for specific images.

convenient side-effect is that this causes these images to build faster on mac because less context needs to be transferred to the docker vm to build the image

@relud relud requested a review from willkg November 4, 2024 18:39
@relud relud requested a review from a team as a code owner November 4, 2024 18:39
Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@relud relud added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 83b0a93 Nov 4, 2024
1 check passed
@relud relud deleted the relud-move-dockerfiles branch November 4, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants