bug-1906108: upgrade markus to 5.0.0 and document metrics #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a statsd_metrics.yaml file that registers all the statsd metrics that Antenna emits. This adds a document_metrics.py Sphinx extension for autogenerating metrics documentation. While doing this, I removed statsd bits from health state since we don't use that anymore.
willkg
force-pushed
the
willkg-bug-1906108-markus
branch
from
4a7b51e
to
f29fa97
Compare
This changes the sentry_scrub_error metric to use the ``socorro.sentry_scrub_error`` key and pass the service as a tag. This matches what we're changing the other Socorro services to do.
This fixes the tests so they set up logging and metrics at pytest session start so that the metrics filters apply to all the tests. This also removes the ``CaptureMetricsUsed`` because we don't need that anymore.
willkg
force-pushed
the
willkg-bug-1906108-markus
branch
3 times, most recently
from
193a9c8
to
5e99958
Compare
willkg
force-pushed
the
willkg-bug-1906108-markus
branch
from
5e99958
to
033e154
Compare
relud
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades Markus to 5.0.0 and documents the metrics. It also does some metrics-related cleanup by removing some things we weren't using.
Note: The first commit is covered in pull #1051. I needed that in order to test changes. We should land that PR first and then rebase this one on top of that one.