bug-1894955: add nginx container to dev and ci environments #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relud
force-pushed
the
relud-bug-1894955-nginx
branch
4 times, most recently
from
d68c0a2
to
6a47fd8
Compare
relud
force-pushed
the
relud-bug-1894955-nginx
branch
2 times, most recently
from
6f224cc
to
75be9ce
Compare
willkg
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
This looks good.
I wonder if we should do something about making sure we update this nginx configuration whenever we update the one in webservices-infra. It doesn't happen often, so maybe a comment in the webservices-infra nginx configuration code to remind us to update this is good enough?
relud
force-pushed
the
relud-bug-1894955-nginx
branch
from
75be9ce
to
21f6386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this enables running system tests for nginx in dev and CI.
for now, this does not publish the container for deployment in GKE.