bug-1894282: Support gcp stage in systemtest #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
reviewed
Apr 30, 2024
| assert status_code == 504 | ||
| assert status_code in ( | ||
| # without LB, nginx drops the connection | ||
| None, |
There was a problem hiding this comment.
What environment do we run the system tests in that doesn't have a load balancer, but does have nginx?
There was a problem hiding this comment.
when i have a spare moment: local dev and CI
There was a problem hiding this comment.
I don't understand what that means. Does that mean you wrote up a bug to change the local dev environment such that it includes nginx running in local dev?
There was a problem hiding this comment.
good point, i have filed a bug about it https://bugzilla.mozilla.org/show_bug.cgi?id=1894955
We should support nginx without a cloud load balancer for a future where that bug is implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemtest/test_env.shneeds an env that points to the gcp stage urlsystemtest/test_content_length.py::TestContentLength::test_content_length_1000needs to accept http 502 from google's load balancer, because it behaves differently from amazon load balancers.