bug-1881575: only require objectUser permissions for GCS #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
reviewed
Apr 30, 2024
| self.client.get_bucket(self.bucket) | ||
| # check if a blob exists to verify GCS is up and we can connect to it, | ||
| # without exceeding the permissions granted by roles/storage.objectUser | ||
| self.client.bucket(self.bucket).blob(generate_test_filepath()).exists() |
There was a problem hiding this comment.
Will the test file always exist? I'm not sure I understand this test and what will happen in this try/except block that catches Exception.
There was a problem hiding this comment.
the test file won't exist, but that's fine because the exists function returns a boolean unless it lacks permissions
willkg
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when deploying antenna in stage, i found it was crashing when
app.verify()was called, and tracked that to not having get bucket permissions.We could grant get bucket permissions, but it seems unnecessary when we could only use the permissions we need.