-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/moveit ros1 ports (backport #3041) #3118
Conversation
* Ports moveit/moveit#3592 * Ports moveit/moveit#3590 * Fixes compile errors --------- Co-authored-by: Sebastian Jahr <sebastian.jahr@picknik.ai> (cherry picked from commit 02ebcba) # Conflicts: # moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp
Cherry-pick of 02ebcba has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## humble #3118 +/- ##
==========================================
- Coverage 51.15% 42.27% -8.88%
==========================================
Files 382 668 +286
Lines 31902 57751 +25849
Branches 0 7322 +7322
==========================================
+ Hits 16317 24406 +8089
- Misses 15585 33159 +17574
- Partials 0 186 +186 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@rr-mark thanks for resolving these! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build failures. There are some renamed member variables with underscores, it seems. Hence the conflicts.
I believe these are sporadic test failures. I've seen it on a few of the humble backports, e.g.: https://github.com/moveit/moveit2/actions/runs/11856401984/job/33042608098 |
Description
This PR ports the following ROS1 PRs to moveit2:
More in-depth descriptions can be found on those pull requests, however, for summary:
Modifies
MoveGroupInterace
to use amoveit_msgs::msgs::RobotSate
as theconsidered_start_state_
RobotState
diffs to avoid passing around large messagesrobot_state::RobotStatePtr
to avoid breaking changesDisables updating of attached collision objects when updating states during a pilz sequence motion
I've more-or-less copied the changes from those PRs in verbatim, so if there are differences in moveit2 that need to be taken into account, let me know and I'll make them.
Checklist
This is an automatic backport of pull request #3041 done by [Mergify](https://mergify.com).