Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue / Refine Layers #182

Merged
merged 30 commits into from
Oct 16, 2024
Merged

Issue / Refine Layers #182

merged 30 commits into from
Oct 16, 2024

Conversation

dncsvr
Copy link
Member

@dncsvr dncsvr commented Oct 7, 2024 •
edited
Loading

Refine existing layers to provide a better developer experience.

Tasks

  • add RuntimeLayer
    • Merge DependencyInjection
    • Merge Configuration
    • Merge Monitoring
  • refactor config building to simplify DataAccess layer
    • expose FluenConfiguration as configuration target
    • allow other features to configure MaxFetchDepth and ShowSql
      • e.g., logging should enable showsql, orm should set maxfetchdepth
    • move registering services to OnDispose
    • move auto creating schema out of registering ISession factory
      • application started is not working while testing, PostBuild can be an
        alternative
  • update docs and samples

Additional Tasks

  • provide a better way to introduce logging

@dncsvr dncsvr self-assigned this Oct 7, 2024
@dncsvr
add Runtime layer and extensions
08cff6f 
- merge `DependencyInjection` layer and extensions into ``Runtime`
@dncsvr
rename DependencyInjection to Runtime in documentation
14d3131
@dncsvr
merge Monitoring layer and extensions into Runtime
18f3ad8
@dncsvr
merge Configuration layer and extensions into Runtime
3fcccd4
@dncsvr
add configuring four phase layer test case to architecture providing …
4d843c8 
…configurations
@dncsvr
expose fluent configuration to features
21572f9 
- add helpers to set maxFetchDepth and showSql from features
@dncsvr
move registering data access services to ondispose action
929c438 
- move set nhibernate interceptor to post build phase
- move export schema to post build phase
- revert changes in persistence configuration
@dncsvr
fix export schema scoped session issue
9ed6281 
- edit in-memory db configuration to be shared between multiple connections
- update data access documentation
@dncsvr
add GetServiceScope helper
ec2eefd
@dncsvr
update samples project
cd545b3 
- add entity extensions sample
- add configuration overrider and override route parts convention
@dncsvr
update unreleased.md
4f827ba
@dncsvr dncsvr marked this pull request as ready for review October 10, 2024 12:55
cihandeniz
cihandeniz reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@cihandeniz cihandeniz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not finished the review, fix issues so far, i'll continue

samples/event-scheduler/src/Mouseless.EventScheduler/DeleteMeetingContact.cs Outdated Show resolved Hide resolved
...Service.Application/Authentication/FixedBearerToken/FixedBearerTokenAuthenticationFeature.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/DataAccessExtensions.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/DataAccessLayer.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/PersistenceConfiguration.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Logging/Request/RequestLoggingFeature.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Orm/AutoMap/AutoMapOrmFeature.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Runtime/Configuration/Settings.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Runtime/DependencyInjection/IServiceAdder.cs Outdated Show resolved Hide resolved
test/core/Baked.Test.Architecture/Architecture/Layer/ProvidingConfiguration.cs Outdated Show resolved Hide resolved
@dncsvr
review changes
b8c57ea 
- move runtime helper classes and interfaces to `Baked.Runtime` and remove extra folders
- change `Settings` namespace to `Baked`
- use scope with curly braces in export schema
- edit schedular entity extensions sample
@dncsvr
update layer document generic arguments count to four
0732287
@dncsvr
add update schema helper
1b31b04
@dncsvr
minor format edit
34f53c9
@dncsvr
move configuration extensions to Runtime folder
e2565fe
@dncsvr
remove show sql from logging feature
b006e30
cihandeniz
cihandeniz reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@cihandeniz cihandeniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

full review

src/recipe/Baked.Recipe.Service.Application/Database/MySql/MySqlDatabaseFeature.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Database/PostgreSql/PostgreSqlDatabaseFeature.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Runtime/RuntimeExtensions.cs Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Runtime/RuntimeLayer.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/Runtime/RuntimeLayer.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/DataAccessLayer.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/DataAccessExtensions.cs Outdated Show resolved Hide resolved
src/recipe/Baked.Recipe.Service.Application/DataAccess/DataAccessExtensions.cs Outdated Show resolved Hide resolved
src/core/Baked.Architecture/Architecture/LayerBase.cs Outdated Show resolved Hide resolved
@dncsvr
review changes
8f8aef2 
- remove `HttpServer` layer dependency of `Runtime` layer
- add `ILoggingBuilder` implementation
- convert `UpdateSchema` parameters to required
- remove `LayerBase` generic implementation with four phases
@dncsvr
remove show sql helper
8cec6e2 
- minor edits
@dncsvr
fix multiline formatting
471e6eb
@dncsvr
edit AddFromAssembly order in RuntimeExtensions
87bce91
@dncsvr
refactor accessing scoped services with service provider accessors
4e45db6 
- create and dispose scope for each test run
- `HttpServer` register service provider accessor with request services
- `TestLayer` registers service provider accessor with scope
- refactor service factories and helper methods to use new service provider accessors
@dncsvr
fix unused parameters error
8603db1
@dncsvr dncsvr merged commit 0d8f82f into mouseless:main Oct 16, 2024
8 checks passed
@dncsvr dncsvr deleted the issue/refine-layers branch October 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cihandeniz cihandeniz cihandeniz approved these changes

Assignees

@dncsvr dncsvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dncsvr @cihandeniz