Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Graphviz/dot: support node and edge links #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mosra
Copy link
Owner

@mosra mosra commented Oct 15, 2018

This again turned out to be way more time consuming than expected and I need to do other things right now, so postponing until I have time again. Things to do:

  • A separate regex that matches nodes and edges with links and converts them to CSS classes that m.css understand
  • There's a separate <g id="a_edge1&#45;label"> for the edge label which should be removed and replaced with just <g>
  • Update test files for graphviz 2:36 and 2.38 (ugh)
  • Doxygen XML output doesn't properly replace \refs with links, even though it does so for HTML output. Yet another pointless annoying unnecessary difference with the XML output, need to submit a PR to doxygen to fix this. Ugh. If anybody is willing to go through this for me, I'll be eternally grateful.
  • Add links to graphs on the Using Magnum with custom buildsystems page

A workaround for now, until the above is done, could be:

  • don't use node/edge links (heh)
  • or apply this half-done PR locally and hardcode the URLs (eww)

Cc: @jbakosi

@mosra mosra self-assigned this Oct 15, 2018
@mosra mosra changed the title [WIP?] Graphviz/dot: support node and edge links [WIP] Graphviz/dot: support node and edge links Oct 15, 2018
@mosra mosra added the help wanted Suitable for a community contribution. label Oct 15, 2018
@mosra mosra added the 3rd party Requires a modification to a 3rd party project. label Nov 12, 2018
TODO: there's a separate <g id="a_edge1&#45;label"> for the edge
label which should be removed and replaced with just <g>
TODO: update test files for graphviz 2:36 and 2.38 (ugh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Requires a modification to a 3rd party project. help wanted Suitable for a community contribution.
Projects
Status: 3rd party TODO
Development

Successfully merging this pull request may close these issues.

1 participant