-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update systemio.h #291
base: master
Are you sure you want to change the base?
Update systemio.h #291
Conversation
Elaborated descriptions as per issue mortbopet#122
Thank you for taking a stab at the issue! I've updated the issue slightly to better reflect what I'd hope to see wrt. better documentation - tl;dr it's concerning the info that's displayed when you open the system call menu. |
@mortbopet Description: However could you please share the file location where the changes need to be made. I have not been able to find it . Thanks! |
2nd argument here is the description that'll appear in the dialog Line 17 in c36b9c7
|
@mortbopet I have made the changes to |
Great, thanks! I think the description should also include information about the different flags that the user can provide as argument - that, or just point to a link describing these since i assume it's documented somewhere in the RISC-V ABI. |
Added flag description.
@mortbopet I have updated the flag description. Please check and let me know if any modifications are needed. |
@mortbopet has the build failed due to the flag description which I have added? Is there any documentation/resource I can look into to fix this issue. I am still a beginner in open source and I would really appreciate your guidance. |
Correct - make sure that the application is able to build successfully locally; looks like this is an issue with |
@mortbopet has this issue been reassigned? I was busy with University stuff hence was off GitHub for a few days. |
Also when can we expect to hear about the status of our LFX mentorship application. |
The issue in question is that there's an issue in the code you submitted, where |
@mortbopet I will start working on it then. Thanks! |
Elaborated descriptions as per issue #122