Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting of wifi channels 12 and 13 #144

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Enable setting of wifi channels 12 and 13 #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2cc223
Remove workaround of buggy code
martignoni Oct 27, 2024
02d404a
Update release notes
martignoni Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](https://semver.org/) and follow principles of [keep a changelog](https://keepachangelog.com).

## Version 2.18.2, unreleased

__This version is not compatible with versions of Moodle prior to Moodle 4.4!__

### Fixed
- Channels 12 and 13 for wireless AP can be selected (issue #144).

## Version 2.18.1, 2024-10-13

__This version is not compatible with versions of Moodle prior to Moodle 4.4!__
Expand Down
4 changes: 0 additions & 4 deletions bin/changewifisettings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@ def do_channel():
new_channel = default_channel
# new_channel is now valid.
if is_networkmanager():
# Workaround bug in NetworkManager: country_code is not used, so if new_channel is 12 and 13,
# we revert to default_channel (11).
# See https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues/960.
new_channel = str(min(int(default_channel), int(new_channel)))
# Set channel with nmcli
subprocess.run(['sudo', 'nmcli', 'con', 'mod', 'WifiAP', 'wifi.channel', new_channel])
else:
Expand Down
Loading