-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: swipe typing duplicate word issue fixed (@HemendraSinghShekhawat) #6018
Open
HemendraSinghShekhawat
wants to merge
2
commits into
monkeytypegame:master
Choose a base branch
from
HemendraSinghShekhawat:fix/swipe-typing-duplicate-word-issue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: swipe typing duplicate word issue fixed (@HemendraSinghShekhawat) #6018
HemendraSinghShekhawat
wants to merge
2
commits into
monkeytypegame:master
from
HemendraSinghShekhawat:fix/swipe-typing-duplicate-word-issue
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any suggestions, as this is my first PR. |
How are you testing swipe typing on a desktop machine? |
Miodec
added
the
waiting for review
Pull requests that require a review before continuing
label
Nov 14, 2024
liamstamper
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic looks good, code is concise and well commented. Meets applicable checks.
This PR is stale. Please trigger a re-run of the PR check action. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
User interface or web stuff
waiting for review
Pull requests that require a review before continuing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed: swipe type duplication error fixed for English.
NOTE: (not checked on another languages, don't know if that is even possible)
Asked ChatGPT on how to create a PR : ) (thanks for monkeytype btw)
related issue: #5624
Swipe type video on local:
monkey-type-swipe-type.mp4
Checks
_list.json
,_groups.json
and addlanguages.json
?