New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #811 correct typing on diskspace and check for NaN #812

Merged

marikaris merged 1 commit into master from fix/diskfull-message-always-shown

Oct 22, 2024

Collaborator

marikaris commented Oct 22, 2024 •

edited

Loading

how to test:

Once built, go to https://preview-armadillo-pr-812.dev.molgenis.org/
Login, see if the diskspace error is there:

Screenshot 2024-10-22 at 11 27 08

If it's not there, the PR works (it did show up on every preview)

To do:

Test if works
Code review


          fix: #811 correct typing on diskspace and check for NaN

49fd2ae

sonarcloud bot commented Oct 22, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

timcadman approved these changes

View reviewed changes

marikaris merged commit e603d3a into master

3 checks passed

marikaris deleted the fix/diskfull-message-always-shown branch

October 22, 2024 10:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet