Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #799 empty linkfile name #800

Merged
merged 8 commits into from
Oct 17, 2024
Merged

fix: #799 empty linkfile name #800

merged 8 commits into from
Oct 17, 2024

Conversation

marikaris
Copy link
Collaborator

@marikaris marikaris commented Oct 10, 2024 •
edited
Loading

how to test:

todo:

  • updated docs in case of new feature
  • added tests

@marikaris marikaris changed the title Fix/779 empty linkfile name fix: #799 empty linkfile name Oct 10, 2024
@marikaris marikaris linked an issue Oct 11, 2024 that may be closed by this pull request
Linkfiles with empty name can be created (but not deleted) #799
Closed
mswertz
mswertz approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code okay

erikzwart
erikzwart approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@erikzwart erikzwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test on preview, created a Project cohort and folder test. Uploaded nonrep.parquet file and tried to create a linkfile. See 'correct' error message:

image

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@marikaris marikaris merged commit a3bcf5e into master Oct 17, 2024
3 checks passed
@marikaris marikaris deleted the fix/779-empty-linkfile-name branch October 17, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzwart erikzwart erikzwart approved these changes

@mswertz mswertz mswertz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linkfiles with empty name can be created (but not deleted)
3 participants
@marikaris @mswertz @erikzwart