Solve a TODO comment in a private method of base_cache::Inner

Replace `entry.last_modified().is_none()` with `entry.is_dirty()`.
moka-rs · Aug 19, 2023 · f8c516a · f8c516a
1 parent ec396f2
commit f8c516a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/future/base_cache.rs b/src/future/base_cache.rs
@@ -2081,8 +2081,7 @@ where
                 }
                 Self::handle_remove(deqs, timer_wheel, entry, &mut eviction_state.counters);
             } else if let Some(entry) = self.cache.get(hash, |k| k == key) {
-                // TODO: CHECKME: Should we check `entry.is_dirty()` instead?
-                if entry.last_modified().is_none() {
+                if entry.is_dirty() {
                     deqs.move_to_back_ao(&entry);
                     deqs.move_to_back_wo(&entry);
                 } else {

diff --git a/src/sync_base/base_cache.rs b/src/sync_base/base_cache.rs
@@ -2100,8 +2100,7 @@ where
                 }
                 Self::handle_remove(deqs, timer_wheel, entry, &mut eviction_state.counters);
             } else if let Some(entry) = self.cache.get(hash, |k| k == key) {
-                // TODO: CHECKME: Should we check `entry.is_dirty()` instead?
-                if entry.last_modified().is_none() {
+                if entry.is_dirty() {
                     deqs.move_to_back_ao(&entry);
                     deqs.move_to_back_wo(&entry);
                 } else {