Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remove method to return Option<V> for unsync cache #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JokerXiL
Copy link

With current implementation of unsync cache, it is possible for the invalidate method to return previous cached value.

I modified it and put it as new remove method.

@tatsuya6502 tatsuya6502 changed the base branch from main to v0.11.x September 12, 2024 21:16
@tatsuya6502 tatsuya6502 changed the base branch from v0.11.x to main September 12, 2024 21:16
@tatsuya6502 tatsuya6502 self-requested a review September 12, 2024 21:17
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (309fa89) to head (7cad7fd).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   91.84%   91.60%   -0.24%     
==========================================
  Files          23       23              
  Lines        4097     4112      +15     
==========================================
+ Hits         3763     3767       +4     
- Misses        334      345      +11     

@tatsuya6502
Copy link
Member

Kani CI will never finish and will be canceled by GitHub Actions. Let's ignore it. We already have a workaround #41 for it on the v0.11.x branch.

@tatsuya6502 tatsuya6502 modified the milestones: v0.11.0, v0.10.4 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants