Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #35

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Fix clippy warnings #35

merged 2 commits into from
Sep 8, 2024

Conversation

GnomedDev
Copy link
Contributor

I also took the liberty to reduce the size of table_mask to u32 as it's originally u32 anyway.

@tatsuya6502 tatsuya6502 self-requested a review September 8, 2024 10:30
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (af40a12) to head (19db541).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   91.90%   91.84%   -0.06%     
==========================================
  Files          23       23              
  Lines        4125     4097      -28     
==========================================
- Hits         3791     3763      -28     
  Misses        334      334              

@GnomedDev
Copy link
Contributor Author

Huh, looks like the kani run was cancelled?

@tatsuya6502
Copy link
Member

Hi. Thank you for creating this pull request.

It looks like Kani's failure is unrelated to the change in this pull request, because the same failure is happening on #34 (DashMap 6). Our Kani job runs only on the frequency_sketch module, and #34 did not change the module.

I see Kani's version has changed from the last successful run. It was v0.54.0, and now it is v0.55.0. So perhaps Kani v0.55.0 has some problems?

@GnomedDev
Copy link
Contributor Author

GitHub seems to be saying "Error: The operation was canceled." in the logs, like it was manually cancelled or something. Anyway, we can ignore that for now.

Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks good to me.

@tatsuya6502 tatsuya6502 merged commit 7b7a522 into moka-rs:main Sep 8, 2024
13 of 14 checks passed
@GnomedDev GnomedDev deleted the fix-clippy branch September 8, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants