fix(bulk-model-sync-lib): use carriage returns only on TTYs #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhuster23
reviewed
Dec 7, 2023
bulk-model-sync-lib/src/commonMain/kotlin/org/modelix/model/sync/bulk/ModelImporter.kt
Outdated
Show resolved
Hide resolved
languitar
force-pushed
the
bugfix/progress-without-ttys
branch
from
6141c6c
to
22e3f9c
Compare
slisson
previously approved these changes
Dec 18, 2023
The implemented progress reporting in the ModelImporter always used carriage returns to report progress. This only works in terminals and breaks incremental logging in setups like k8s. This commit tries to detect if running in a terminal and if not, resorts to logging calls for progress reporting. Logging output is reduced to avoid excessive spam in captured log file.
languitar
force-pushed
the
bugfix/progress-without-ttys
branch
from
22e3f9c
to
3c5ad06
Compare
|
I've rebased this to the current main. |
mhuster23
approved these changes
Dec 21, 2023
|
🎉 This PR is included in version 3.17.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implemented progress reporting in the ModelImporter always used carriage returns to report progress. This only works in terminals and breaks incremental logging in setups like k8s.
This commit tries to detect if running in a terminal and if not, resorts to logging calls for progress reporting. Logging output is reduced to avoid excessive spam in captured log file.