Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Replaced Values #181

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Return Replaced Values #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions Sources/CodableDatastore/Datastore/Datastore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,14 +653,15 @@ extension Datastore where AccessMode == ReadWrite {
/// - Parameters:
/// - instance: The instance to persist.
/// - idenfifier: The unique identifier to use to reference the item being persisted.
public func persist(_ instance: CodedType, to idenfifier: IdentifierType) async throws {
@discardableResult
public func persist(_ instance: CodedType, to idenfifier: IdentifierType) async throws -> CodedType? {
try await warmupIfNeeded()

let updatedDescriptor = try self.updatedDescriptor(for: instance)
let versionData = try Data(self.version)
let instanceData = try await self.encoder(instance)

try await persistence._withTransaction(
return try await persistence._withTransaction(
actionName: "Persist Entry",
options: [.idempotent]
) { transaction, _ in
Expand Down Expand Up @@ -869,6 +870,8 @@ extension Datastore where AccessMode == ReadWrite {
datastoreKey: self.key
)
}

return existingInstance
}
}

Expand All @@ -879,7 +882,8 @@ extension Datastore where AccessMode == ReadWrite {
/// - Parameters:
/// - instance: The instance to persist.
/// - keypath: The keypath the identifier is located at.
public func persist(_ instance: CodedType, id keypath: KeyPath<CodedType, IdentifierType>) async throws {
@discardableResult
public func persist(_ instance: CodedType, id keypath: KeyPath<CodedType, IdentifierType>) async throws -> CodedType? {
try await persist(instance, to: instance[keyPath: keypath])
}

Expand Down Expand Up @@ -1018,15 +1022,23 @@ extension Datastore where CodedType: Identifiable, IdentifierType == CodedType.I
/// If an instance does not already exist for the specified identifier, it will be created. If an instance already exists, it will be updated.
/// - Parameter instance: The instance to persist.
@_disfavoredOverload
public func persist(_ instance: CodedType) async throws where AccessMode == ReadWrite {
@discardableResult
public func persist(_ instance: CodedType) async throws -> CodedType? where AccessMode == ReadWrite {
try await self.persist(instance, to: instance.id)
}

@_disfavoredOverload
public func delete(_ instance: CodedType) async throws where AccessMode == ReadWrite {
@discardableResult
public func delete(_ instance: CodedType) async throws -> CodedType where AccessMode == ReadWrite {
try await self.delete(instance.id)
}

@_disfavoredOverload
@discardableResult
public func deleteIfPresent(_ instance: CodedType) async throws -> CodedType? where AccessMode == ReadWrite {
try await self.deleteIfPresent(instance.id)
}

@_disfavoredOverload
public func load(_ instance: CodedType) async throws -> CodedType? {
try await self.load(instance.id)
Expand Down
Loading