Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

IOS-3269 :: Feature internal :: configure step in the GitHub action to execute swift lint + swift format #47

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

migueltorcha
Copy link
Contributor

I have split the tasks in step by step commits, so you can discard or reorder any of them

Merge / Pull request information:

@migueltorcha migueltorcha force-pushed the feature/3269_configure_step_in_the_github_action_to_execute_swift-lint_+_swift-format branch from 2b5c56a to 064c9aa Compare September 30, 2022 15:02
@migueltorcha
Copy link
Contributor Author

It was failing due to the legacy_random commit. I've removed it. On the other hand, I'll mark this PR as draft, since it looks to be some inconsistencies between .swiftlint.yml and .swiftformat files.
Both tools are automatically fixing issues with their own commands:

  • swiftlint lint --fix --format
  • swiftformat .
    If you compare the commits where I apply those commands, you'll see that each tool is reformatting the code in it's own way. You'll need to make the applied rules compatibles. I did't try, but probably you can use this sample:

https://medium.com/glovo-engineering/linting-and-formatting-swift-code-in-our-apps-a49dc0a52332

@migueltorcha migueltorcha marked this pull request as draft September 30, 2022 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant