PR: 4주차 과제 - Gang #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
12
to
26
| const SkeletonMain = () => { | ||
| return ( | ||
| <S.SkeletonWrapper> | ||
| <SkeletonBase $width="200px" $height="300px" /> | ||
| </S.SkeletonWrapper> | ||
| ); | ||
| }; | ||
| export default SkeletonMain; | ||
|
|
||
| const SkeletonWrapper = styled.div` | ||
| width: 200px; | ||
| height: 300px; | ||
| display: grid; | ||
| overflow: hidden; | ||
| `; |
There was a problem hiding this comment.
불필요하게 컴포넌트가 분리되어 있다고 느껴집니다.
- 일단 SkeletonBase 의 props 전달에 문제가 있어보여요,
$width->width로 해야할 것 같습니다. SkeletonMain는SkeletonBase의 크기를 조정하는 게 목적인가요?- 그게 맞다면,
SkeletonBase컴포넌트의 width, height 모두 100% 로 미리 설정하고, 크기와 관련된 props 를 받지 못하도록,,, (저라면 그렇게) 설계할 것 같습니다.!
- 그게 맞다면,
There was a problem hiding this comment.
main page에서 사용하기 위한 스켈레톤 컴포넌트 입니다
Comment on lines
6
to
24
| const ImageLoader = ({ src, sizes, srcSet }) => { | ||
| const [loading, setLoading] = useState(true); | ||
|
|
||
| return ( | ||
| <Container> | ||
| {loading && <SkeletonMain />} | ||
| <ImageWrapper> | ||
| <Image | ||
| alt="image" | ||
| fetchPriority="high" | ||
| src={src} | ||
| sizes={sizes} | ||
| srcSet={srcSet} | ||
| onLoad={() => setLoading(false)} | ||
| /> | ||
| </ImageWrapper> | ||
| </Container> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
👍
이미지 로딩 중 skeleton 출력하는 것과 관련해서, 1조가 이 방법 말고 다른 방법을 찾은게 있습니다.
조금 더 코드가 간결해 지더라구요.! 한번 읽어봐주세요.
load 되지 않는 동안 출력없이 src 에 대한 데이터만 불러오고, 완전히 load 되면 그때 출력하는 방법인 것 같습니다.!
week4/src/App.js
Outdated
Comment on lines
1
to
20
| import "./App.css"; | ||
|
|
||
| import { Provider } from "react-redux"; | ||
|
|
||
| import store from "./libs/redux/store"; | ||
| import Main from "./page/main"; | ||
| import GlobalStyle from "./styles/global-style"; | ||
|
|
||
| function App() { | ||
| return ( | ||
| <> | ||
| <Provider store={store}> | ||
| <GlobalStyle /> | ||
| <Main /> | ||
| </Provider> | ||
| </> | ||
| ); | ||
| } | ||
|
|
||
| export default App; |
week4/src/components/common/box.jsx
Outdated
There was a problem hiding this comment.
오.. 혹시 이게 headless 인가요?? 😮
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1, Task 2, Task 3
Task 4
Task 5
Task 6