Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

모범 사례로 선정된 Code PR #2

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

모범 사례로 선정된 Code PR #2

wants to merge 19 commits into from

Commits on Jul 6, 2023

  1. chore: project init

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    047a59f View commit details
    Browse the repository at this point in the history

  2. design: global, theme 스타일 적용 & 폰트 적용

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    79019e9 View commit details
    Browse the repository at this point in the history

  3. design: 기본 레이아웃 틀 구성

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    b08fda2 View commit details
    Browse the repository at this point in the history

  4. feat: 기본 페이지들 구성 및 라우팅

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8617662 View commit details
    Browse the repository at this point in the history

  5. chore: logo 이미지 추가 및 body 기본 스타일 추가

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    16f4c85 View commit details
    Browse the repository at this point in the history

  6. design: common, theme 속성 일부 추가

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    d5b69bd View commit details
    Browse the repository at this point in the history

  7. design: 사이드바 퍼블리싱 완료 

    * 반응형으로는 기능 구현 후 예정입니다 :)
    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    a27dbdd View commit details
    Browse the repository at this point in the history

  8. feat: 선택한 페이지에 맞게 사이드바 목록에 포커스되는 기능 추가

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8dc64b2 View commit details
    Browse the repository at this point in the history

  9. feat: 새로고침 시에도 열려있던 title 유지되도록 기능 추가

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    88f0151 View commit details
    Browse the repository at this point in the history

  10. chore: 주석 추가 및 props명 변경

    @Doeunnkimm
    Doeunnkimm committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    916bdf8 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. fix: 뒤로가기 시 이전 페이지 토클이 열리지 않는 이슈 해결

    @Doeunnkimm
    Doeunnkimm committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d0b60fe View commit details
    Browse the repository at this point in the history

  2. Update README.md

    @Doeunnkimm
    Doeunnkimm authored Jul 7, 2023
    Configuration menu
    Copy the full SHA
    bfd0361 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Merge pull request #1 from mobi-community/feat/challenge-1/doeunnkimm 

    chore: best practice 산출
    @Doeunnkimm
    Doeunnkimm authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    9a864cf View commit details
    Browse the repository at this point in the history

  2. Update README.md

    @Doeunnkimm
    Doeunnkimm authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    b775a23 View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @Doeunnkimm
    Doeunnkimm authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    dfeb174 View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @Doeunnkimm
    Doeunnkimm authored Jul 8, 2023
    Configuration menu
    Copy the full SHA
    aa54ead View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. refactor: 불필요한 드릴링 제거(isNowTitle)

    @Doeunnkimm
    Doeunnkimm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    ed2befc View commit details
    Browse the repository at this point in the history

  2. fix: isOpenToggle이 isNowTitle에 의존하도록 하는 코드 제거

    @Doeunnkimm
    Doeunnkimm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    e5719d3 View commit details
    Browse the repository at this point in the history

  3. fix: 뒤로가기 시 닫혀있던 토글이 열리지 않던 이슈 해결

    @Doeunnkimm
    Doeunnkimm committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3120106 View commit details
    Browse the repository at this point in the history