Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with poetry and tests #17

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Set up CI with poetry and tests #17

merged 6 commits into from
Dec 7, 2023

Conversation

wpietri
Copy link
Contributor

@wpietri wpietri commented Dec 7, 2023

No description provided.

@wpietri wpietri requested a review from a team as a code owner December 7, 2023 19:41
Copy link

github-actions bot commented Dec 7, 2023

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wpietri
Copy link
Contributor Author

wpietri commented Dec 7, 2023

Ok, I think this is actually ready for review. @dhosterman, please merge if it you like it. And @brianwgoldman , your suggested improvements to running tests were spot on and are in here, so this should now work better for you.

Copy link
Collaborator

@dhosterman dhosterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dhosterman dhosterman merged commit 64d7390 into main Dec 7, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@wpietri wpietri deleted the wpietri-ci-attempt branch December 7, 2023 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants