Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed configureDependencies return type #158

Conversation

utpal-barman
Copy link
Collaborator

General

Using void is throwing an error in another project right now where we have a global cubit with multiple use cases as dependencies while opening it complains that the cubit is not registered, I found out that—the cubit was not ready for use while using for the first time, so we must add Future as return type, then it works! injectable official documents are proposing void but should be Future<T>.

Checklists

  • Platform specific changes (input, image picking etc) are tested on both of the platforms (Android and iOS)
  • It is tested that the UI changes are rendered correctly on different device sizes (such as long lists or expanded rows) with safe area conditions.
  • Edge cases, such as responses being empty or invalid, missing data, no internet connection etc, are tested and the app works as expected.

Showcase

  • Either showcase screenshots / videos are attached, or this PR does not require such any showcase.

@utpal-barman utpal-barman merged commit b12a540 into ml-opensource:master Oct 22, 2024
1 check passed
@utpal-barman utpal-barman deleted the fix/configure-dependencies-awaited branch October 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant