Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While publishing in opam repository, I realized calling
dune runtest
would fail because we weren't tracking the dependency innode_modules
anywhere (it was assumed thatnpm install
would be called manually).This PR adds this dependency inside dune itself by leveraging the recently added directory targets. ref: ocaml/dune#6168.
The
yarn.lock
was removed as it would lead to permission issues:As there are barely any deps and we are already constraining to minor versions of them, we should be fine.