Add ARIA 1.1 into global-attributes #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rcelona/jsoo-react into Add-aria-into-global-attributes * 'Allow-global-attributes-on-svg' of github.com:/ml-in-barcelona/jsoo-react: feat: Moved global_attributes into svg feat: Remove contextMenu as global attrs
davesnx
force-pushed
the
Add-aria-into-global-attributes
branch
from
7f7be93
to
9b0e7f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from
html.mlintoDom_global_attributesthe aria props from JSX.I left the comments as regular comments, and not ocaml.doc to not start with the documentation for some of the attributes.
I left some of the polymorphism commented as well, until we decide/action this issue: #69