Merge pull request #1586 from minvws/5672

friendlier message for those who cannot preview the pdf
minvws · Jun 20, 2023 · 936871d · 936871d
2 parents 8123b35 + c4a742f
commit 936871d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/holder/src/main/java/nl/rijksoverheid/ctr/holder/pdf/PdfPreviewFragment.kt b/holder/src/main/java/nl/rijksoverheid/ctr/holder/pdf/PdfPreviewFragment.kt
@@ -48,9 +48,9 @@ class PdfPreviewFragment : Fragment(R.layout.fragment_pdf_preview) {
                     navigateSafety(
                         PdfPreviewFragmentDirections.actionDialog(
                             data = DialogFragmentData(
-                                title = R.string.dialog_error_title,
-                                message = R.string.general_diskFull_body,
-                                positiveButtonData = DialogButtonData.NavigateUp(R.string.ok)
+                                title = R.string.holder_pdfExport_storageFull_errorDialog_title,
+                                message = R.string.holder_pdfExport_storageFull_errorDialog_message,
+                                positiveButtonData = DialogButtonData.NavigateUp(R.string.dialog_close)
                             )
                         )
                     )

diff --git a/holder/src/main/res/values-en/strings.xml b/holder/src/main/res/values-en/strings.xml
@@ -690,7 +690,7 @@
   <string name="holder_pdfExport_start_message">Create a file from your certificates that you can share, save on your phone or tablet, or print. This can be done until the end of this year (2023).</string>
   <string name="holder_pdfExport_start_buttonTitle">Create certificate</string>
   <string name="holder_pdfExport_success_title">Success!</string>
-  <string name="holder_pdfExport_success_message">You can share, save, send or print the file with your certificates below.</string>
+  <string name="holder_pdfExport_success_message">You can share, save or print the file with your certificates below.</string>
   <string name="holder_pdfExport_card_description">You can still save your certificates until the end of this year. Creating new certificates is no longer possible.</string>
   <string name="holder_menu_exportPDF">Save my certificates</string>
   <string name="holder_pdfExport_card_action">Save my certificates</string>
@@ -707,4 +707,6 @@
   <string name="holder_pdfExport_start_toolbar">Save certificate</string>
   <string name="holder_pdfExport_success_toolbar">File created</string>
   <string name="holder_pdfExport_error_body" formatted="false"><![CDATA[Something is going wrong while creating the file with your certificates.<br/><br/>Do you have questions about this? Please contact the helpdesk via <a href=\"tel:%s\">%s</a>and pass on the below error code.<br/><br/><b>Error code:</b><br />%s]]></string>
+  <string name="holder_pdfExport_storageFull_errorDialog_title">Not possible to preview file</string>
+  <string name="holder_pdfExport_storageFull_errorDialog_message">It’s currently not possible to preview this file. However, you can choose \'Save file\' if you want to share, save or print it.</string>
 </resources>
diff --git a/holder/src/main/res/values/strings.xml b/holder/src/main/res/values/strings.xml
@@ -690,7 +690,7 @@
   <string name="holder_pdfExport_start_message">Maak een bestand van je bewijzen dat je kunt delen, opslaan op je telefoon of tablet, of printen. Dit kan nog tot eind dit jaar (2023).</string>
   <string name="holder_pdfExport_start_buttonTitle">Maak bestand</string>
   <string name="holder_pdfExport_success_title">Gelukt!</string>
-  <string name="holder_pdfExport_success_message">Het bestand met jouw bewijzen hieronder kun je delen, opslaan, versturen of printen.</string>
+  <string name="holder_pdfExport_success_message">Het bestand met jouw bewijzen hieronder kun je delen, opslaan of printen.</string>
   <string name="holder_pdfExport_card_description">Je kunt nog tot eind dit jaar je bewijzen bewaren. Nieuwe bewijzen maken kan niet meer.</string>
   <string name="holder_menu_exportPDF">Mijn bewijzen bewaren</string>
   <string name="holder_pdfExport_card_action">Mijn bewijzen bewaren</string>
@@ -707,4 +707,6 @@
   <string name="holder_pdfExport_start_toolbar">Bewijs bewaren</string>
   <string name="holder_pdfExport_success_toolbar">Bestand gemaakt</string>
   <string name="holder_pdfExport_error_body" formatted="false"><![CDATA[Er gaat iets mis met het maken van het bestand met je bewijzen.<br/><br/>Heb je vragen? Bel de helpdesk op <a href=\"tel:%s\">%s</a> en geef onderstaande foutcode door.<br/><br/><b>Foutcode:</b><br />%s]]></string>
+  <string name="holder_pdfExport_storageFull_errorDialog_title">Bestand bekijken niet mogelijk</string>
+  <string name="holder_pdfExport_storageFull_errorDialog_message">Momenteel kun je dit bestand niet bekijken. Je kunt wel kiezen voor ‘Bestand bewaren’ als je het wilt delen, opslaan of printen.</string>
 </resources>