-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Snowplow/BigQuery support & more flexible Snowplow Redshift table selection #9
Draft
kingo55
wants to merge
25
commits into
mint-metrics:master
Choose a base branch
from
kingo55:bigquery-models
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got experiment reports working from our Snowplow/BigQuery GCP pipeline. Will run you through it tomorrow, but here's a summary:
Summary of report config changes
Source tables are defined in
wave_params
This allows us to define specific custom schemas, tables, views or subqueries as required by different experiments.
This does away with the - often confusing -
wave_params$client_id
andwave_params$subject
abomination of table naming we have used previously. This should make things easier for other users to adopt reports.Change to the way goals are defined
BigQuery's regex functions are a bit awkward to use and don't fit into the format we're used to:
REGEXP_CONTAINS(goal, r'^transaction [0-9]+(something|anotherthing)')
This is in contrast to Redshift's regex match:
goal ~ '^transaction [0-9]+(something|anotherthing)'
Due to this, I think we can combine the "goal" and "operand" parameters that we pass into reports, into just the one
goal
parameter:BigQuery time grains are less flexible
Whereas with Redshift we could specify time grains in plural or singular form, BigQuery only accepts the singular form, which we may need to handle for. E.g. in time to convert plots we use the SQL time grain.
Other notable changes
It looks like GCP is reporting slightly more traffic/conversions. But incredibly close considering we're comparing two different pipelines here
TODO
Update Redshift reports to line up with BigQuery
As much as possible, I'd like to make it easy to migrate our Redshift knits over to BigQuery. This includes:
Rework segments implementation
I think now might be a good time to rethink how we apply segments. Especially considering how we might do it cost effectively with BigQuery.