Add luacheck, repo cleanup

.gitattributes

@@ -1,17 +1,2 @@
 # Auto detect text files and perform LF normalization
-* text=auto
-
-# Custom for Visual Studio
-*.cs     diff=csharp
-
-# Standard to msysgit
-*.doc	 diff=astextplain
-*.DOC	 diff=astextplain
-*.docx diff=astextplain
-*.DOCX diff=astextplain
-*.dot  diff=astextplain
-*.DOT  diff=astextplain
-*.pdf  diff=astextplain
-*.PDF	 diff=astextplain
-*.rtf	 diff=astextplain
-*.RTF	 diff=astextplain
+* text=auto

.github/workflows/luacheck.yml

@@ -0,0 +1,10 @@
+name: luacheck
+on: [push, pull_request]
+jobs:
+  luacheck:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@master
+      - name: Luacheck
+        uses: lunarmodules/luacheck@master

.luacheckrc

@@ -0,0 +1,8 @@
+read_globals = {
+	"minetest",
+	"default"
+}
+
+globals = {
+	"castle_shields"
+}

default_shields.lua

@@ -2,25 +2,14 @@ minetest.register_alias("castle:shield", "castle_shields:shield_1")
 minetest.register_alias("castle:shield_2", "castle_shields:shield_2")
 minetest.register_alias("castle:shield_3", "castle_shields:shield_3")
 
+-- Translation support
+local S = minetest.get_translator("castle_shields")
 
--- Used for localization, choose either built-in or intllib.
+-- The following colors are permitted:
+-- "black", "blue", "brown", "cyan", "dark_green", "dark_grey", "green", "grey",
+-- "magenta", "orange", "pink", "red", "violet", "white", "yellow"
 
-local MP, S, NS = nil
-
-if (minetest.get_modpath("intllib") == nil) then
-	S = minetest.get_translator("castle_shields")
-
-else
-	-- internationalization boilerplate
-	MP = minetest.get_modpath(minetest.get_current_modname())
-	S, NS = dofile(MP.."/intllib.lua")
-
-end
-
-
---The following colors are permitted:
--- "black", "blue", "brown", "cyan", "dark_green", "dark_grey", "green", "grey", "magenta", "orange", "pink", "red", "violet", "white", "yellow"
---The following patterns are permitted:
+-- The following patterns are permitted:
 -- "slash", "chevron", "cross"
 
 -- method parameters are name, desc, background_color, foreground_color, pattern

locale/castle_shields.it.tr

@@ -1,3 +1,2 @@
-# textdomain:castle_shields
-
+# textdomain: castle_shields
 Mounted Shield=Scudo appeso

locale/template.txt

@@ -1,3 +1,2 @@
-# textdomain:castle_shields
-
+# textdomain: castle_shields
 Mounted Shield=

mod.conf

@@ -1,4 +1,3 @@
 name = castle_shields
 description = Adds decorative wall shields
-depends = default, dye
-optional_depends = intllib
+depends = default, dye

shield_functions.lua

@@ -1,15 +1,16 @@
 castle_shields.register_shield = function(name, desc, background_color, foreground_color, mask, disable_recipe)
 
 	local tile_side = "castle_shield_"..background_color..".png"
-	local tile_front = "castle_shield_"..background_color..".png^(castle_shield_"..foreground_color..".png^[mask:castle_shield_mask_"..mask..".png)"
+	local tile_front = "castle_shield_"..background_color..".png^(castle_shield_"..foreground_color..
+			".png^[mask:castle_shield_mask_"..mask..".png)"
 
 	minetest.register_node(minetest.get_current_modname()..":"..name, {
 		description = desc,
 		tiles = {tile_side, tile_side, tile_side, tile_side, "castle_shield_back.png", tile_front},
-		drawtype="nodebox",
+		drawtype = "nodebox",
 		paramtype2 = "facedir",
 		paramtype = "light",
-		groups={cracky=3},
+		groups = {cracky=3},
 		sounds = default.node_sound_metal_defaults(),
 		node_box = {
 			type = "fixed",
@@ -27,7 +28,7 @@ castle_shields.register_shield = function(name, desc, background_color, foregrou
 			},
 		},
 	})
-	
+
 	if disable_recipe then
 		-- recipe disabled by caller
 		return